[isf-wifidog] [Fwd: login error]

[Benoit Grégoire]

On Friday 01 April 2005 08:07, Philippe April wrote:
> On 1-Apr-05, at 7:49 AM, Benoit Grégoire wrote:
> > On Thursday 31 March 2005 21:28, Philippe April wrote:
> >> I put "global $db" at the top of the function  to fix the issue also,
> >> if you haven't seen.
> >>
> >> I suppose it was only doing this for some users, but still... $db was
> >> not accessible for that case so that's why he got the message.
> >
> > Yes, I saw.
> >
> >> I'd like to bring the issue of the config.php too.
> >>
> >> I really hate the fact that we put our particular config, in CVS. I
> >> think we should have a config.php.template (generic one), that people
> >> have to copy to config.php.
> >
> > The auth server will read local.config.php if present.  However, there
> > is no
> > way to automatically update with new config options.  I think it's
> > critical
> > that the config.php in CVS is always complete and valid.
>
> I would really like to start changing the way we're doing the config
> and schema changes. I brought this up in the past already.
>
> Basically I would like to start tagging releases (between major
> changes), split the design much more (make a generic config + style
> available, and make our ISF a 'skin' that people don't have to put up
> with when they install wifidog-auth) and when we change the schema,

You are the onw who moved away from that.  It was the reason why the local 
content stylesheets applied to the whole server, and at the time, I don't 
believe there was any string specific to ISF anywhere in the code or the 
templates. 

> well we make it another release and have a little documentation on
> "what changed between this and that release" + a little upgrade script.

We already do, it's called the ChangeLog.  NEWS will be pulled from it once we 
make releases.  As for the schema, it already automatically updated itself, 
and sync_sql_for_cvs works pretty well to keep schemas for new installs 
working.

> I really hate the fact that our production running config is in CVS!
> I'd like something more generic to be in CVS, no tweaks, no hacks.

What tweaks, what hacks?
-- 
Benoit Grégoire, http://benoitg.coeus.ca/
-------------- section suivante --------------
Une pièce jointe non texte a été nettoyée...
Nom: non disponible
Type: application/pgp-signature
Taille: 189 octets
Desc: non disponible
Url: http://listes.philippeapril.com/pipermail/wifidog/attachments/20050401/59a26fee/attachment.pgp