[isf-wifidog] gateway (sort of) fork

Benoit Grégoire benoitg at coeus.ca
Lun 7 Juil 10:57:10 EDT 2008

On 7 July 2008, Wichert Akkerman wrote:
> Gateway development seems to be dormant at the moment; I needed a couple
> of extra features, all of which I added with working patches to the
> bugtracker but so far almost none of them have been merged or commented
> upon.

True, almost none of them has been merged yet.  However, as far as I know, 
they have all been discussed or commented upon on one furum or another.

> Therefore I've imported the gateway code into a git repository
> and added all my changes in there. The current changes are:
> - support for multiple gateway instances on a single server
>   This branches has fixes for tickets #457, #473, #464,

As discussed, these are all fine, just need to get reviewed/merged.  Alex is 
busy right now, so am I , and I am focussing on other issues.  I'm quite 
willing to give your commit access so your can merge them, as long as you 
don't merge the next two.

> - add interface to allow an auth server to immediately disconnect a user
>   This fixes ticket #465
> - optionally protect the gateway status screen with a password
>   This fixes ticket #463

As we both discussed at length, 465 is problematic, as it violates two 
fundamental design decisions of the gateway:  Don't move intelligence to the 
gateway unless there is no way for the auth server to make the decision, and 
never assume that the gateway is reachable from the outside.

Furthermore, if a configurable reaction delay is not sufficient for your use, 
the, you should be able to set your bandwidth and time limits in the token 
transmitted to the gateway (well, probably, Philippe is still opposed to thet 
change, but I'm pretty sure he'd be opposed to your way of doing it even 

As for #463, It's really only necessary because of your request in #465.  
However I'd be fine with a config option to turn off the satus page 

> - CSS fix in the error page so it renders correctly in all browsers

That's good, obviously.

Benoit Grégoire
Technologies Coeus inc.

Plus d'informations sur la liste de diffusion WiFiDog