[isf-wifidog] manual vs. automatic logout behavioural differences

[Wichert Akkerman]

I just submitted http://dev.wifidog.org/ticket/457 but figured that may
warrant a bit of discussion here, esp. in light of the new protocol work
being done.

At the moment the manual logout behaviour is inconsistent with the
standard idle-timeout based logout:

* on idle-timeout and logout message always has both incoming and
  outgoing counters set to 0. For manual logout to are set to the last
  measured value

* with idle-timeout there is always a counter message before the logout
  message so you can be sure you have the correct values. With manual
  logout the data from the last measurement is used, which has already
  been transmitted in an earlier counters message.

To make things more consistent I'ld like to propose the following:

- on automatic logout: do not send both a counters and a logout message,
  but only send a logout message with correct counter values.

- on manual logout: update the counters and use the new numbers in the
  logout message

that makes everything consistent and reduces the number of messages send
to the auth server.

Wichert.

-- 
Wichert Akkerman <wichert at wiggy.net>    It is simple to make things.
http://www.wiggy.net/                   It is hard to make things simple.