[isf-wifidog] Bug in fw_iptables.c
Philippe April
isf_lists at philippeapril.com
Lun 15 Oct 23:42:56 EDT 2007
Ok! J'ai commité la modification. J'ai vérifié, et ça règle bien le
problème.
Je te laisserais releaser 1.1.4, vu que je n'ai plus trop la main...
On 15-Oct-07, at 10:56 PM, Benoit Grégoire wrote:
>> So basically the -D in FW_ACCESS_DENY just "deletes" the "ACCEPT
>> line".
>
> Darn, I missed the -D when I did the audit to create the dia
> firewall map in
> doc/.
>
> We should change to long style iptables parameters in the code, it
> would
> improve readability quite a bit.
>
>> I would personally suggest releasing a 1.1.4... It leaves entries in
>> mangle until wifidog is restarted (it clears all chains it created).
>> More importantly, it messes up the stats for a user who logs back in
>> during the same wifidog process. To reproduce:
>
> Yes, it definitely warrants a 1.1.4
>
>> Benoit, should I just commit the code once you confirm?
>
> Yes you should. And I confirm.
>
> --
> Benoit Grégoire
> Technologies Coeus inc.
Plus d'informations sur la liste de diffusion WiFiDog