[isf-wifidog] mac-address patch cry for help

Saul Albert saul at twenteenthcentury.com
Mar 24 Mai 07:15:29 EDT 2005


On Mon, May 23, 2005 at 07:40:36PM -0400, Mina Naguib wrote:
> What happens when you run it ? Does it cause WiFiDog to crash or behave 
> weirdly ?

I think schuyler didn't even compile and test it, just wrote it and said
- that should work. :) 

I removed the bit this bit from the patch:

--------------------------------------

diff -Naur wifidog-1.1.1/src/conf.h wifidog-1.1.1-autoid/src/conf.h
--- wifidog-1.1.1/src/conf.h    2004-11-22 21:45:57.000000000 +0000
+++ wifidog-1.1.1-autoid/src/conf.h     2005-05-18 20:22:10.000000000
+0100
@@ -29,11 +29,10 @@
 
 /*@{*/ 
 /** Defaults configuration values */
 #define DEFAULT_CONFIGFILE "/etc/wifidog.conf"
 #define DEFAULT_DAEMON 1
 #define DEFAULT_DEBUGLEVEL LOG_INFO
 #define DEFAULT_HTTPDMAXCONN 10
-#define DEFAULT_GATEWAYID "default"
+#define DEFAULT_GATEWAYID NULL
 #define DEFAULT_GATEWAYPORT 2060
 #define DEFAULT_HTTPDNAME "WiFiDog"
 #define DEFAULT_CLIENTTIMEOUT 5

------------------------------------------

because patch seemed to he having trouble applying it.. and I couldn't
see the reason for it (as you said)

then I compiled it this morning and installed it.
http://chinabone.lth.bclub.org.uk/~saul/docs/code/wifidog/wifidog_1.1.1_mipsel.ipk

and configured it as normal, and it runs fine.

but no mac address in the ping as far as I can see. I'm too code-blind to
know why.

> Also note that get_iface_mac returns something like AABBCCDDEEFF 
> instead of AA:BB:CC:DD:EE:FF.  Let me know if you were expecting it to 
> do the later.

No - we want it without the ::: so we can pass it to the ping that the
router sends to the auth server on startup.

> Finally, I'm not patching it into the main wifidog tree yet since I'm 
> still waiting developer feedback.  I'm also not convinced that setting 
> DEFAULT_GATEWAYID to NULL instead of "default" (hence populating it 
> with the mac) is the default behavior we want to distribute wifidog 
> with.

right. I don't think that bit matters particularly to us, unless I'm
really mising something. This is core to what we want to do with the
splash server - and if you do decide to roll it in we'll be very happy
indeed.

Have you tried compiling this? Does it work at all for you?

Cheers,

Saul.






Plus d'informations sur la liste de diffusion WiFiDog