[isf-wifidog] mac-address patch cry for help

Mina Naguib webmaster at topfx.com
Lun 23 Mai 19:40:36 EDT 2005


On 23-May-05, at 7:01 PM, Saul Albert wrote:

> On Mon, May 23, 2005 at 06:48:40PM -0400, Mina Naguib wrote:
>> Hello Saul
>>
>> I'll adopt your patch.
>
> yaay!
>
>> 1. Cool idea!
>
> thanks, it's jo walsh's :)
>
>> 2. Good code. Looks fine. You're even using safe_strdup !
>
> thanks, it's schuyler's
>
>> 3. Are you posting it here asking for help ? Is it not working as
>> expected ?
>
> it's not working, and since Schuyler has driven off to Malaga and is
> off-line for this week, jo and I have been left scratching our heads,
> looking at Schuyler's patch and wondering why not. I guess Schuyler
> wasn't familiar enough with wifidog's guts to get it working easily
>
>> and finally for wifidog group:
>> 4. This is cool bean. You plop the MAC address of the wifi interface 
>> in
>> the auth server and there's no need to configure the gateway ID in the
>> client.  Does anyone see a reason why not to incorporate this into our
>> tree ?
>
> please! if you can make this work, we will be immensely grateful.
>

What happens when you run it ? Does it cause WiFiDog to crash or behave 
weirdly ?

If so, I believe the fix is in adding this line somewhere early in 
get_iface_mac:
memset(mac, 0, sizeof(mac));

Also note that get_iface_mac returns something like AABBCCDDEEFF 
instead of AA:BB:CC:DD:EE:FF.  Let me know if you were expecting it to 
do the later.

Finally, I'm not patching it into the main wifidog tree yet since I'm 
still waiting developer feedback.  I'm also not convinced that setting 
DEFAULT_GATEWAYID to NULL instead of "default" (hence populating it 
with the mac) is the default behavior we want to distribute wifidog 
with.




Plus d'informations sur la liste de diffusion WiFiDog